Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 30 30
Lines 2907 2907
=======================================
Hits 2380 2380
Misses 527 527 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamTakeshi
force-pushed
the
improve-sim-scalability
branch
from
322e5f7 to
7fa7d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the main problem on simulator frontend.
The problem was related to the filter callback. By default, the hook updates its internal state on every incoming message, which causes the component to re-render. Now its set to false to never update the FE, only when we want (with
onWsMessage)The simulator before worked fine with ~30 dotbots on my machine, but now seems fine with ~200. (only tested with changing colors).
I found a couple more improvements, will test and send improvements in small PRs.
recording.7.webm